Remove legacy events multiple template and js file #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deedeeh
commented
Dec 19, 2023
| ### Automated ads | ||
|
|
||
| A number of ads (`events-multiple` and `masterclass-multiple`) use a reader revenue endpoint. In their associated `test.json` files you will see that the URL's refer to `mem.thegulocal.com` as the domain. The `_src/js/events-multiple.js` needs to be updated to reflect this domain also. This requires the [`membership-frontend`](https://github.com/guardian/membership-frontend) to be running and using the `nginx` server. Make sure to set this up before testing these ads. | ||
|
|
There was a problem hiding this comment.
I spoke to Emma regarding this and she said we can remove this section as events-multiple is migrated to Svelte and masterclass-multiple have been shut down.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR removes the Legacy
events-multipletemplate after it's been migrated to Svelte #333.How to test
You can see that
events-multipleisn't used in Legacy anymore in here https://guardian.github.io/commercial-templates/ and I checked ifapiMultiplefunction which is inevents-multiple.jshas been used in any files in our codebase before removing it.How can we measure success?
Remove unused Legacy templates and related files after migration for cleaner codebase.